Fix: Add _classes to hotgrid__item (fixes #143)

[swashbuck]

Fix #143

Fix

• Adds the _items._classes to .hotgrid__item to assist with styling.
• Retains the custom class on the Hotgrid popups.

[oliverfoster]

Should probably put it on .hotgrid__item and not .hotgrid__item-btn

[swashbuck]

Should probably put it on .hotgrid__item and not .hotgrid__item-btn

Yep, done. I initially had it on hotgrid__item-btn since that's where the other classes were (is-round, is-visited, etc).

[oliverfoster]

Yep, done. I initially had it on hotgrid__item-btn since that's where the other classes were (is-round, is-visited, etc).

Yea it's curious.

[kirsty-hames]

Yep, done. I initially had it on hotgrid__item-btn since that's where the other classes were (is-round, is-visited, etc).

Yea it's curious.

I think Hotgrid was based on Hotgraphic initially so this has probably carried over. Hotgraphic appends _classes and state classes to the button (.hotgraphic__pin / .hotgraphic__tile).

[kirsty-hames]

This works as expected thanks @swashbuck. One thing to note, Hotgraphic has separate _classes for popup and item. Would we want to do the same here for consistency?

Although I do find it odd that the Hotgraphic popup _classes is associated with the graphic when the class is applied to the .hotgraphic-popup__item.

[swashbuck]

This works as expected thanks @swashbuck. One thing to note, Hotgraphic has separate _classes for popup and item. Would we want to do the same here for consistency?

Although I do find it odd that the Hotgraphic popup _classes is associated with the graphic when the class is applied to the .hotgraphic-popup__item.

Thanks, @kirsty-hames . I agree that we should align with Hotgraphic's classes implementation, as flawed as it is. I'll add a new _classes property to each Hotgrid item's _graphic object. Then, maybe in the future, we can look into changing both Hotgraphic and Hotgrid's implementation so that it makes more sense.

[swashbuck]

@kirsty-hames @oliverfoster These changes have been made. Ready for re-review.

[kirsty-hames]

Thanks @swashbuck - works as expected.

[github-actions]

🎉 This PR is included in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀