Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Title is required to set notify popup dialog label (fixes #146) #147

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix: Title is required to set notify popup dialog label (fixes #146) #147

merged 1 commit into from
Mar 1, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #146

Fix

  • Set title as required. Without a title, the popup dialog won't be properly identified by assistive technologies.

@kirsty-hames kirsty-hames self-assigned this Jan 31, 2024
swashbuck
swashbuck approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit ff44ce2 into master Mar 1, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/146 branch March 1, 2024 08:47
github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
@semantic-release-bot
Chore(release): 4.5.2 [skip ci]
0ab9354 
## [4.5.2](v4.5.1...v4.5.2) (2024-03-01)

### Fix

* Set properties.schema item title to required (#147) ([ff44ce2](ff44ce2)), closes [#147](#147)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 4.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames kirsty-hames restored the issue/146 branch March 7, 2024 16:29
@kirsty-hames
Copy link
Contributor Author

re-opening branch to update component schema as per Hotgraphic PR

@kirsty-hames kirsty-hames mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title is required to set notify popup dialog label
3 participants
@kirsty-hames @swashbuck @oliverfoster