Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is required to set notify popup dialog label #146

Closed
kirsty-hames opened this issue Jan 31, 2024 · 0 comments · Fixed by #147 or #148
Closed

Title is required to set notify popup dialog label #146

kirsty-hames opened this issue Jan 31, 2024 · 0 comments · Fixed by #147 or #148
Assignees
@kirsty-hames
Labels
accessibility

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

As per Core issue Notify role="dialog" requires a label. The popup uses the title to set the dialog label.

Expected behaviour

Title should be set to required as without this, the popup dialog won't be properly identified by assistive technologies.
@kirsty-hames kirsty-hames self-assigned this Jan 31, 2024
@kirsty-hames kirsty-hames mentioned this issue Jan 31, 2024
Merged
@kirsty-hames kirsty-hames mentioned this issue Mar 7, 2024
Merged
kirsty-hames added a commit that referenced this issue May 7, 2024
@kirsty-hames
Update: set item Title as required in component schema (fixes #146) (#…
3f71514 
…148)
github-actions bot pushed a commit that referenced this issue May 7, 2024
@semantic-release-bot
Chore(release): 4.6.0 [skip ci]
6ba1542 
# [4.6.0](v4.5.3...v4.6.0) (2024-05-07)

### Update

* set item Title as required in component schema (fixes #146) (#148) ([3f71514](3f71514)), closes [#146](#146) [#148](#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility
Projects
None yet
Milestone
No milestone
1 participant
@kirsty-hames