Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplicate code across plugins using notify popup #126

Closed
kirsty-hames opened this issue May 24, 2023 · 1 comment · Fixed by #127
Closed

Reduce duplicate code across plugins using notify popup #126

kirsty-hames opened this issue May 24, 2023 · 1 comment · Fixed by #127
Assignees
@kirsty-hames
Labels
enhancement released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the enhancement

As per adaptlearning/adapt-contrib-vanilla#443, the default style for Notify icon buttons is consistent across all plugins however we've duplicated the styling code across the various plugin LESS files in Vanilla and Hotgrid.

Suggest applying .notify__btn-icon to .hotgrid-popup__controls and .hotgrid-popup__close so styles inherit from Vanilla notify.less. Duplicate styles can then be removed from the LESS.
This means the default style is set in one place but we still have plugin specific classes to target should you want to style these different - although there's good reason for keeping UI button styling consistent.
@kirsty-hames kirsty-hames self-assigned this May 24, 2023
@kirsty-hames kirsty-hames mentioned this issue May 24, 2023
Merged
kirsty-hames added a commit that referenced this issue Jul 4, 2023
@kirsty-hames
Update: add generic .notify__btn-icon class (fixes #126) (#127)
1a738f2 
* add generic .notify__btn-icon class

* remove duplicate LESS

as these now inherit from .notify__btn-icon in Vanilla notify.less
github-actions bot pushed a commit that referenced this issue Jul 4, 2023
@semantic-release-bot
Chore(release): 4.4.0 [skip ci]
2590135 
# [4.4.0](v4.3.16...v4.4.0) (2023-07-04)

### Update

* add generic .notify__btn-icon class (fixes #126) (#127) ([1a738f2](1a738f2)), closes [#126](#126) [#127](#127)
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🎉 This issue has been resolved in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: add generic .notify__btn-icon class (fixes #126) cgkineo/adapt-hotgrid
1 participant
@kirsty-hames