Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor theme logic #216

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: refactor theme logic #216

wants to merge 3 commits into from

Conversation

diogogmatos
Copy link
Member

@diogogmatos diogogmatos commented May 22, 2024

This PR introduces a new hook to manage themes, uniting theme logic that is currently duplicated in the events and schedule pages.

BUG:

  1. Open settings
  2. Select 'Custom' theme
  3. Change 'Customize by' to 'Year'
  4. Change 'Customize by' to 'Subject' again.
  5. TypeError: subjectColors.find(...) is undefined error is shown.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for cesium-calendarium ready!

Name Link
🔨 Latest commit 8b897a8
🔍 Latest deploy log https://app.netlify.com/sites/cesium-calendarium/deploys/66e07544ea5cae00097f61c7
😎 Deploy Preview https://deploy-preview-216--cesium-calendarium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos diogogmatos self-assigned this Sep 10, 2024
@diogogmatos diogogmatos added the help wanted Extra attention is needed label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant