Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tst: fix reverse_dns test #2208

Merged
merged 1 commit into from
Jul 6, 2022
Merged

tst: fix reverse_dns test #2208

merged 1 commit into from
Jul 6, 2022

Conversation

wagner-intevation
Copy link
Contributor

remove test_invalid_ptr as the IP address used no longer returns the
expected result

fixes #2206

remove test_invalid_ptr as the IP address used no longer returns the
expected result

fixes #2206
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #2208 (7969687) into develop (79cae29) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2208      +/-   ##
===========================================
- Coverage    76.34%   76.22%   -0.13%     
===========================================
  Files          441      441              
  Lines        23654    23632      -22     
  Branches      3739     3437     -302     
===========================================
- Hits         18059    18013      -46     
- Misses        4858     4880      +22     
- Partials       737      739       +2     
Impacted Files Coverage Δ
...elmq/tests/bots/experts/reverse_dns/test_expert.py 100.00% <ø> (ø)
intelmq/bots/experts/reverse_dns/expert.py 83.87% <0.00%> (-11.30%) ⬇️
intelmq/bots/experts/mcafee/expert_mar.py 35.55% <0.00%> (-8.89%) ⬇️
intelmq/bots/experts/modify/expert.py 92.00% <0.00%> (-5.34%) ⬇️
intelmq/bots/parsers/dshield/parser_domain.py 95.45% <0.00%> (-4.55%) ⬇️
intelmq/tests/lib/test_exceptions.py 95.65% <0.00%> (-4.35%) ⬇️
intelmq/bots/collectors/opendxl/collector.py 30.15% <0.00%> (-3.18%) ⬇️
intelmq/bots/parsers/dshield/parser_block.py 87.50% <0.00%> (-2.50%) ⬇️
intelmq/bots/collectors/tcp/collector.py 84.31% <0.00%> (-1.97%) ⬇️
intelmq/bots/parsers/generic/parser_csv.py 85.18% <0.00%> (-1.86%) ⬇️
... and 12 more

@sebix sebix added this to the 3.1.0 milestone Jul 6, 2022
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: tests labels Jul 6, 2022
@sebix sebix merged commit e606efc into develop Jul 6, 2022
@sebix sebix deleted the fix-2206 branch July 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestReverseDnsExpertBot.test_invalid_ptr fails because of DNS entry change
4 participants