Fix reconnection in SQL Mixin #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameters show not be changed during runtime, this prevents reloading the bot and other re-initializations (self.engine was made a class instance)
separate the sql mixin initialization from the __init__ to be able to call it from inside the bot for re-connecting. calling self.__init__ would require at least the bot-id calling self._connect would require preparing all the arguments fixes certtools#2200
Codecov Report
@@ Coverage Diff @@
## develop #2201 +/- ##
========================================
Coverage 76.34% 76.34%
========================================
Files 441 441
Lines 23654 23657 +3
Branches 3739 3739
========================================
+ Hits 18059 18062 +3
Misses 4858 4858
Partials 737 737
|
waldbauer-certat
approved these changes
Jul 12, 2022
sebix
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200:
exceptionparameters show not be changed during runtime, this prevents reloading
the bot and other re-initializations (self.engine was made a class
instance)
separate the sql mixin initialization from the
__init__to be able tocall it from inside the bot for re-connecting.
calling
self.__init__would require at least the bot-idcalling
self._connectwould require preparing all the arguments