-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Use redis BLMOVE instead of BRPOPLPUSH (deprecated) #2149
Conversation
54305be
to
4b6843a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2149 +/- ##
===========================================
- Coverage 76.34% 76.30% -0.05%
===========================================
Files 441 441
Lines 23652 23649 -3
Branches 3739 3739
===========================================
- Hits 18058 18046 -12
- Misses 4857 4864 +7
- Partials 737 739 +2
|
4b6843a
to
114cf81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLMOVE is
Available since: 6.2.0
Source: https://redis.io/commands/blmove/
For example, Debian Bullseye (11) has version 6.0. Just switching to BLMOVE will cause massive turbulences for the users, requiring them to switch to rolling release distros, PPA et. al. or compiling redis themselves.
I propose to support redis < 6.2.0 too.
aba42d0
to
58d76e4
Compare
Fixes #1827 Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
58d76e4
to
8c8702b
Compare
As BRPOPLPUSH has been marked as deprecated in favor of BLMOVE.
Fixes #1827