Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: imap collector: support unverified connections #2055

Merged
1 commit merged into from
Aug 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2021

use existing standard http_verify_cert parameter to determine if
certificate should be checked or not.
default (backwards-compatible) is to verify the server certificate

cc @th-certbund

use existing standard http_verify_cert parameter to determine if
certificate should be checked or not.
default (backwards-compatible) is to verify the server certificate
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Aug 19, 2021
@ghost ghost added this to the 3.1.0 milestone Aug 19, 2021
@ghost ghost self-requested a review August 19, 2021 20:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #2055 (d7aa71e) into develop (e489bee) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop    #2055      +/-   ##
===========================================
- Coverage    75.99%   75.98%   -0.01%     
===========================================
  Files          428      428              
  Lines        23002    23005       +3     
  Branches      3061     3062       +1     
===========================================
+ Hits         17480    17481       +1     
- Misses        4815     4816       +1     
- Partials       707      708       +1     
Impacted Files Coverage Δ
intelmq/bots/collectors/mail/_lib.py 67.27% <60.00%> (-1.96%) ⬇️

@ghost ghost merged commit 34e83bd into develop Aug 23, 2021
@ghost ghost deleted the wagner/enh-mail-unverified branch August 23, 2021 09:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant