Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the harmonization attribute of the bot private #2049

Merged
1 commit merged into from
Aug 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2021

that way we can exclude it from attribute listings of the bots
attributes.

@ghost ghost force-pushed the schacht/make-harmonization-private branch 2 times, most recently from 182a797 to 970da45 Compare August 18, 2021 11:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2049 (db52a1c) into develop (ff7d835) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    75.98%   75.99%   +0.01%     
===========================================
  Files          428      428              
  Lines        23002    23003       +1     
  Branches      3062     3061       -1     
===========================================
+ Hits         17477    17481       +4     
+ Misses        4817     4815       -2     
+ Partials       708      707       -1     
Impacted Files Coverage Δ
intelmq/lib/bot.py 62.48% <100.00%> (+0.42%) ⬆️
intelmq/bots/parsers/shadowserver/_config.py 97.27% <0.00%> (ø)

intelmq/lib/bot.py Outdated Show resolved Hide resolved
@ghost ghost force-pushed the schacht/make-harmonization-private branch from 970da45 to 3b8b281 Compare August 18, 2021 13:13
that way we can exclude it from attribute listings of the bots
attributes.
@ghost ghost force-pushed the schacht/make-harmonization-private branch from 3b8b281 to db52a1c Compare August 19, 2021 07:16
@ghost ghost marked this pull request as ready for review August 19, 2021 07:18
@ghost ghost merged commit 9550f86 into develop Aug 23, 2021
@ghost ghost deleted the schacht/make-harmonization-private branch August 23, 2021 07:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant