Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.6 #2272

Closed
kamil-certat opened this issue Nov 17, 2022 · 5 comments · Fixed by #2294
Closed

Drop support for Python 3.6 #2272

kamil-certat opened this issue Nov 17, 2022 · 5 comments · Fixed by #2294

Comments

@kamil-certat
Copy link
Contributor

kamil-certat commented Nov 17, 2022 •
edited
Loading

Python 3.6 is already EOL. We can drop support and update docs, requirements files and package definitions.

Before that, the question should be sent to the mailing list to be sure that no one needs/wants to maintain it.

Follow of #2262
@kamil-certat
Copy link
Contributor Author

The email was sent.

For clean up:
the harmonization.py contains some compatibility code for Python lower than 3.6

@gethvi gethvi mentioned this issue Nov 22, 2022
Closed
@kamil-certat
Copy link
Contributor Author

New reason for dropping: Github Action doesn't have Python 3.6 for the Ubuntu 22.04, which now is the ubuntu-latest. This means, our CI is at the moment blocked.

@aaronkaplan
Copy link
Member

The email was sent.

For clean up: the harmonization.py contains some compatibility code for Python lower than 3.6

I did not look into that yet.

@aaronkaplan
Copy link
Member

keeping open , so far only did the unit test python 3.6 CI removal. See #2281
Still need to look at the code

@sebix
Copy link
Member

sebix commented Dec 21, 2022

3.6 is still mentioned in the setup.py

kamil-certat added a commit to kamil-certat/intelmq that referenced this issue Jan 5, 2023
@kamil-certat
ENH: Fully droped Python 3.6. Updated syntax.
7ab08a3 
All references to Python 3.6 are updated or explicitly mentioned
as no longer supported. The syntax was updated to use newer features.

In addition, the changelog was fixed by removing already fixed known
issues and moving wrong-placed entry.

Closes certtools#2272
@kamil-certat kamil-certat mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Drop Python 3.6 and enable 3.11 kamil-certat/intelmq
3 participants
@sebix @aaronkaplan @kamil-certat