allow bots check() method to run from test without full initialization

[bernhardreiter]

Allow the check() methods of bots to run in automatic tests.

Right now the check() can happen without all full libraries imported, to check for the existence of parameters, e.g. in

intelmq/intelmq/bots/outputs/misp/output_feed.py

Line 106 in ec0e911

def check(parameters):

It can be good to use the code for automatic tests as well. For this the prepare_bot() method
of

intelmq/intelmq/lib/test.py

Line 187 in ec0e911

def prepare_bot(self, parameters={}, destination_queues=None):

would need to be split up, so that the init() method of the bot to be tested is not called. At least this would be needed if check() is used like it is in the MISP Output bot above.

[ghost]

You mean like this?
8543735

[bernhardreiter]

Thanks for suggestion and improvement. Right now I cannot test it, so maybe. ;) It looks a bit too simple, when I remember what I had tried, but maybe I did not understand enough when trying to poke around.

[ghost]

It looks a bit too simple,

That's what I thought too :) However, the static check methods are called.

[ghost]

Based on what I coded in spring last year, I further added tests on the check's return values.

With the upcoming changes in the configuration handling, the check method will gain more functionalities.