Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter feed to name for collectors #1144

Closed
ghost opened this issue Dec 20, 2017 · 0 comments · Fixed by #1241
Closed

Rename parameter feed to name for collectors #1144

ghost opened this issue Dec 20, 2017 · 0 comments · Fixed by #1241
Labels
usability
Milestone
1.1.0

Comments

@ghost
Copy link

ghost commented Dec 20, 2017

Collectors have the common parameter feed. This parameter will be added to events as `feed.name.
Other common parameters (see https://github.com/certtools/intelmq/blob/367e32ddc8b146a1ed768ec93e428559b71cee30/docs/Bots.md) have the same name as parameter and as field. The only inconsistent one is feed → name.

What do others think? This proposal is from a user, forwarded by me.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

DEP: lib/bot: replace parameter feed by name for collectors certtools/intelmq
0 participants