-
Notifications
You must be signed in to change notification settings - Fork 14
feat: use go-ipfs
instead of js-ipfs
#13
feat: use go-ipfs
instead of js-ipfs
#13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions
@smrz2001 I don't think this should be the goal. In our 3box labs terraform repo we should be able to use tfvars file in whatever way is easiest for us, but in the examples here we should make it as clear as possible to people how to use the module, ideally with as little effort as possible on their part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things but should be good after that
Makes sense, @v-stickykeys. We should work towards adding more resources here as well (e.g. S3 bucket, etc.) that must be created outside of these scripts. |
@smrz2001 can you update readme to include instructions about peer id and private key? |
…raform-aws # Conflicts: # modules/ecs/ipfs/variables.tf # modules/ecs/main.tf
No description provided.