chore: change ipfs default to remote mode and remove bundled ceramic-one #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AES-231: remove-bundled-mode-and-default-to-c1-url-as-localhost5101 edited as I put 230 instead of 231 in the branch name |
3 tasks
dav1do
force-pushed
the
chore/aes-230-remove-c1-bundled
branch
from
afc75b1
to
a35e90d
Compare
stbrody
approved these changes
Jul 18, 2024
Co-authored-by: Spencer T Brody <spencer+github@3box.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default IPFS mode is now remote with localhost:5101 (ceramic-one). We no longer support starting the ceramic-one binary automatically in bundled mode outside of tests. It didn't provide a super elegant startup as we don't have a good cross platform install method for node so couldn't guarantee the defaults and it isn't how we want people to run things anyway. It also had some issues stopping, especially when errors occur during start up and rather than rework that handling, we're moving away from the option.
This changes the default config options to remote ceramic one, so it doesn't "just work" if you run
node ceramic.js daemonlike it would before. If you previously had bundled mode in your config, you will get an error saying it's not supported and you should pass a url.Note
The local CI still passes as we're starting in bundled mode for the tests, however, the daemon is no longer able to do that so the verifyImage task fails. It will require validating and merging the changes in pipeline-tools first before this is fully green.
How Has This Been Tested?
Ran daemon locally and CI.
PR checklist
Before submitting this PR, please make sure:
References:
Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.