feat: ci/cd #10
Merged
feat: ci/cd #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
force-pushed
the
feature/res-1044-deploy-to-dev
branch
from
4fc406a
to
24326e4
Compare
3benbox
approved these changes
Jun 7, 2023
ci/cmd/build/main.go
Outdated
| Platform: "linux/amd64", | ||
| BuildArgs: []dagger.BuildArg{{Name: Env_EnvTag, Value: envTag}}, | ||
| }). | ||
| WithRegistryAuth( |
There was a problem hiding this comment.
It's strange to me that the registry auth is done at this point, before the image is being pushed.
Is that a convenience or a requirement for the dagger client?
There was a problem hiding this comment.
No, it can be moved. The auth token is used during push but I can move the token retrieval closer to the push as well 👍🏼
stephhuynh18
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stephhuynh18 @3benbox, here's the PR for the CASv5 Scheduler CI/CD. I've also opened a separate PR for changes on the CD Manager side.
There is one ugly part of this code that I'm going to fix in a subsequent PR - the Dagger Go dependencies are mixed in with the actual app dependencies. I'm going to pull the Dagger stuff out into its own repo and pull it in during CI/CD workflows instead of running it from within the repo like it is right now.
Steph, I've commented out the unit test piece until we can figure out why that one test case is failing when run via Dagger 😢