Replaces the references to Kubernetes Authors in the copyright #300
Conversation
|
@Madhu-1 Reverted and force pushed with just the author change :) |
|
@wilmardo Thanks for the PR , one small change is required |
|
@Madhu-1 The PR is updated with the request change 👍 |
|
Done! |
|
@phlogistonjohn @rootfs PTAL |
|
@gman0 @j-griffith @ShyamsundarR do you guys agree this change ? |
|
I am good with that change, thanks |
|
Should wait for #297 |
|
Should I change the branch to master? |
|
added DNM label to avoid accidental merging |
There was a problem hiding this comment.
Modifying copyright is always a touchy subject in my experience. There is a significant amount of prior work here from the "Kubernetes Authors".
In the interest of full transparency and not upsetting any involved parties; I'd suggest adding a second copyright rather than replacing. In the case of new files added the old copyright could be dropped. Just something to consider. Personally I don't have a problem with changing it as you have here, but we should make sure it doesn't raise issues for anyone else. This did originate in the kube incubator repo IIRC so.... I dunno.
Oh! I missed the comment from @rootfs, if he's good with it I'm good with it LGTM |
|
can you send this PR to master branch? from now onwards we will be using master for csiv1.0 development, Thanks |
Done! |
Replaces the references to Kubernetes Authors in the copyright
Syncing latest changes from upstream devel for ceph-csi
Fixes: #272
Was looking through the issues and had some time ;)
Just an easy search and replace excluding the vendor directory, replaces the Kubernetes Authors with Ceph-CSI authors and replaces all the years with 2019.