base: add packages for ceph-csi #1337
Conversation
| @@ -12,4 +12,7 @@ | |||
| gdisk \ | |||
| __RADOSGW_PACKAGE__ \ | |||
| __GANESHA_PACKAGES__ \ | |||
| __ISCSI_PACKAGES__ | |||
| __ISCSI_PACKAGES__ \ | |||
| ceph-fuse \ | |||
There was a problem hiding this comment.
I'm wondering if it makes sense to put those packages under CSI_PACKAGES (to be created) wdyt ?
Also I'm not sure those packages are available for all distro/release, did you checked that ?
There was a problem hiding this comment.
Yes, I thought about CSI_PACKAGES, I guess it makes sense to have it if packages are named differently in other distros, I haven't checked that yet.
There was a problem hiding this comment.
I've checked and the three packages are available for all distro/releases
I've updated the PR because there was a typo on __CSI_PACKAGES__ (missing S) and also remove the other empty occurence in ceph-release directory
We want to use our base image for ceph-csi. ceph-csi needs extra packages so we are adding them. Signed-off-by: Sébastien Han <seb@redhat.com>
|
Why doesn't the ceph-csi Dockerfile include these? |
|
@ktdreyer the goal is for ceph-csi to use that our ceph base image so that they don't have to care about the underlying Ceph image. They simply build their binary and put it on top of our image. |
|
@dsavineau good to go? |
|
They can run |
|
@ktdreyer yes, but I don't think we want that either. |
We want to use our base image for ceph-csi. ceph-csi needs extra
packages so we are adding them.
Signed-off-by: Sébastien Han seb@redhat.com