Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playbooks: use group name variables consistently #7609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stuartgrace-bbc
Copy link

In many places, playbooks allow host group names such as 'mons' to be overriden by defining a variable such as 'mon_group_name'. This is very useful when ceph-ansible is sharing the ansible inventory with other playbooks and other hosts which expect different group names. But this was unfinished, with the variables used in some places but hard-coded names used in others places, sometimes within the same playbook.

This commit uses the group name variables everywhere so they can be reliably used to overrride the host group names.

Signed-off-by: Stuart Grace stuart.grace@bbc.co.uk

In many places, playbooks allow host group names such as 'mons' to be
overriden by defining a variable such as 'mon_group_name'. This is
very useful when ceph-ansible is sharing the ansible inventory with
other playbooks and other hosts which expect different group names.
But this was unfinished, with the variables used in some places but
hard-coded names used in others places, sometimes within the same
playbook.

This commit uses the group name variables everywhere so they can be
reliably used to overrride the host group names.

Signed-off-by: Stuart Grace <stuart.grace@bbc.co.uk>
@guits guits added draft and removed draft labels Sep 13, 2024
@gael-api
Copy link

I have a PR with the same goal. (But with unknown commits attached to it)
Some group_names are also present in prometheus jinja file :

I think an all_group_name that replace all generic group must be implemented when inventory used is larger than the simple cluster inventory (as in a cloud dynamic inventory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants