-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collator migration for RTU4 #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
But I would set CandidacyBond
, so that it is not zero and we must not set it manually. But we can also leave it to zero.
if VERSION.spec_version == IntegrateCollatorSelection::<T>::to_version() { | ||
consumed += | ||
IntegrateCollatorSelection::<T>::inject_invulnerables(invulnerables.as_slice()); | ||
consumed += | ||
IntegrateCollatorSelection::<T>::inject_desired_candidates(DESIRED_CANDIDATES); | ||
consumed += IntegrateCollatorSelection::<T>::inject_candidates( | ||
candidates.as_slice(), | ||
CANDIDACY_BOND.into(), | ||
); | ||
consumed += | ||
IntegrateCollatorSelection::<T>::inject_candidacy_bond(CANDIDACY_BOND.into()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still should inject CandidacyBond
and DesiredCandidates
. Or why do you want remove them? Not sure, If they are set correctly if we don`t go through genesis init.
@mustermeiszer We can set both parameters later with the council/democracy. We havent discussed them internally yet so not sure what to set there at the moment. |
No description provided.