feat: LPv2 message reorder #1892

wischli · 2024-06-28T08:34:11Z

Description

Updates messages to match v2 spec
Update LP Integration tests based on reorder submodule branch

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

lemunozm · 2024-07-02T11:58:55Z

pallets/liquidity-pools/src/message.rs

@@ -1044,7 +994,7 @@ mod tests {
 				decimals: 15,
 				restriction_set: 1,
 			},
-			"040000000000000001811acd5b3f17c06841c7e41e9e04cb1b536f6d65204e616d65000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000053594d424f4c00000000000000000000000000000000000000000000000000000f01",
+			"0b0000000000000001811acd5b3f17c06841c7e41e9e04cb1b536f6d65204e616d65000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000053594d424f4c00000000000000000000000000000000000000000000000000000f01",


NIT NIT suggestion:

Maybe this super obscure line becomes clear using the concat! macro: i.e:

concat!( "0b" //msg_id "0000000000000001", //pool_id "811acd5b3f17c06841c7e41e9e04cb1b536f6d65204e616d65", // tranche_id "00000000000000000000000000000000", //... .. )

And becomes easier also to create new tests

…order

lemunozm · 2024-07-10T06:26:42Z

pallets/liquidity-pools/src/message.rs

+		// TODO(@Luis): Apply delta instead of remaining to foreign investments
+		fulfilled_invest_amount: u128,


In FulfilledDepositRequest message the fulfilled amount is not needed.

Anyway, I'm not sure if the solitary side has modified these fields yet. In that case, the error you're experiencing could be due to different format in these messages between us and solidity? (although sure you've already check that)

lemunozm

I understand your concern about merging this with the pending TODOs in integration test. I would consider that merging in feat/lpv2 at this moment does not represent final changes and we can have tech-debts, until having the base of lpv2 logic.

Could we add before merging this an #[ignore] before the failing tests? To allow green CI in the meantime for PRs on top of this.

Are the liquidity pools unitary tests are passing now?

Looks everything pretty good. Thanks for your efforts put on this 💯

pallets/liquidity-pools/src/hooks.rs

runtime/integration-tests/src/cases/lp/investments.rs

runtime/integration-tests/src/cases/lp/mod.rs

runtime/integration-tests/src/cases/liquidity_pools.rs

lemunozm · 2024-07-11T15:23:03Z

If failing tests are #[ignore] and clippy passes (CI in general passes), I would merge this 🚀

lemunozm · 2024-07-12T05:21:44Z

Do we know the right indexes to fix the UTs?

wischli · 2024-07-12T11:47:55Z

Do we know the right indexes to fix the UTs?

Sorry, forgot to push that.

lemunozm · 2024-07-12T12:11:29Z

Once we rebase and fix the pending test, we should protect the feat/lp-v2 branch to only merge if CI passes

* feat: LPv2 message reorder (#1892) * wip: add new msgs + reorder * refactor: apply renaming * fix: ITs * feat: UpdateRestriction message * fix: cancel_unprocessed_investment IT * fix: fmt * fix: clippy * tests: reanchor solidity to reorder branch * feat: apply hook to AddTranche msg * tests: fix pool_management ITs * wip: fix lp investments * fmt * fix: Tranche namespace * refactor: remove fulfilled from FulfilledRedeemRequest * chore: update lp submodule * minor cleanup * chore: update lp submodule * chore: add missing cleanup * fixes + ignore failing tests * fmt * tests: fix message indices * ignore failing tests (#1910) * LPv2: ForeignInvestments changes (#1895) * add uts (#1905) * main changes for FI * fix correlation precission * minor renames * update investment UTs * update redemption UTs * miscelaneous UTs * minor renames * simplify correlation and embed to the only needed place * doc change * remove unused bound * swapping calls into entities.rs file * merge SwapDone methods into FulfilledSwapHook * fix events * working without pallet-swaps * remove boilerplate for removing entries * minor msg change * minor simplification * correct fulfilled sum after last collect * check OrderIdToSwapId storage * sending the message inside Info closure is not really a problem * send msgs from the entities * remove same currency check in impl.rs * unify hooks * remove pallet-swaps * minor fmt * add docs * add architecture diagram * return cancelled foreign amount from FI interface * update liquidity-pools * add messages to diagram * implement hooks * fix runtimes * adapt integration-tests * fix docs * fix clippy * fix clippy * fix tests after merge * fix foreign investment tests (#1918) * ignore failing tests (#1919) * fix previous merge * LP v2: fix integration tests (#1915) * chore: update submodule to latest `main` 6d7f242c0dd83b1b5a4f6d506370a1f3ecbef9ce * wip: fix ITs * chore: update submodule * fix: remove sender param from `Transfer*` messages * chore: cleanup * docs: setup evm * fix: msg tests * fix: more ITs * fix: missing refactor after rebase * chore: update submodule to 223a0f36edabc675f8c74c47b20e366178df7ca3 * chore: improvements * fmt * Apply suggestions from code review * chore: bump spec_version * fmt: taplo * LPv2: Batch Message serialization (#1920) * custo serialize/deserialize for batch * compiling solution * serialization/deserialization working for batch message * remove gmpf changes * add batch nested protection * faster serialization for submessages * correct termination * add tests for deserialize batch of batch * add into_iter * remove unused Box and add pack methods * fix non_std compilation * non_std * fix max_encoded_len recursion issue * fix submodules * reduce batch limit * feat: add domain hook storage (#1928) * refactor: add domain hook address storage * tests: add gateway lp admin account checks * refactor: use GetByKey * fix: outboundq mock * refactor: hook 20 bytes instead of 32 * fix cargo fmt * Feat/lp v2 gateway queue (#1930) * pallets: Add LP Gateway queue pallet * lp-gateway-queue: Add benchmarks * integration-tests: Add LP gateway tests * docs: Update LP gateway queue entry * lp-gateway-queue: Use default weight for PostDispatchInfo * lp-gateway-queue: Add DEFAULT_WEIGHT_REF_TIME const, extract message processing logic, use BaseArithmetic for nonce * runtime: Add defensive weights for LP gateway queue * lint: Obey * taplo: Obey * pallet: Use DispatchResult for extrinsics * runtime: Update benchmarks and weight info * benchmarks: Add default for Message type (wip) * pallet: Add Default bound to Message type * lp-v2: fix message fields (#1933) * fix: add remark call to borrow proxy * fix: add missing message fields * chore: bump to v0.13.3 * chore: update submodule * chore: enable fixed tests --------- Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de> * refactor: cleanup my leftovers (#1935) * LPv2: Bump-up foreign investment. Fix failing investment ITs (#1934) * increase version for foreign investments * fix investment issue * fix solidity call for transfers_tokens * fix tests * minimize required tranche investors for IT * fix docs * fix docs * docs: fix hyperlink * refactor: enable ITs for centrifuge + dev runtimes (#1938) * fix: enable ITs for centrifuge + dev runtimes * fmt * fix: revert some centrifuge ITs * fmt * revert centrifuge addition to ITs --------- Co-authored-by: William Freudenberger <w.freude@icloud.com> --------- Co-authored-by: William Freudenberger <w.freude@icloud.com> Co-authored-by: Cosmin Damian <17934949+cdamian@users.noreply.github.com> Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de>

wip: add new msgs + reorder

09e6567

wischli added this to the Liquidity Pools v2 milestone Jun 28, 2024

wischli self-assigned this Jun 28, 2024

wischli added I6-refactoring Code needs refactoring. D5-breaks-api Pull request changes public api. Document changes publicly. labels Jun 28, 2024

wischli added 6 commits June 28, 2024 10:41

refactor: apply renaming

1301469

fix: ITs

d85f8b2

feat: UpdateRestriction message

c6fc214

fix: cancel_unprocessed_investment IT

0f50e86

fix: fmt

c5a649d

fix: clippy

944da3f

lemunozm reviewed Jul 2, 2024

View reviewed changes

wischli mentioned this pull request Jul 4, 2024

LP Message with custom data format for serialization/deserialization #1889

Merged

wischli added 9 commits July 4, 2024 10:59

tests: reanchor solidity to reorder branch

4db16c0

feat: apply hook to AddTranche msg

b6b6dc8

tests: fix pool_management ITs

924a5c8

wip: fix lp investments

ed444f5

fmt

8520f1d

fix: Tranche namespace

36e4dd4

Merge remote-tracking branch 'origin/feat/lp-v2' into lpv2/message-re…

f393715

…order

refactor: remove fulfilled from FulfilledRedeemRequest

152c317

chore: update lp submodule

88c38de

lemunozm reviewed Jul 10, 2024

View reviewed changes

wischli added 2 commits July 10, 2024 10:06

minor cleanup

3813e45

chore: update lp submodule

241e5ef

lemunozm mentioned this pull request Jul 10, 2024

LPv2: ForeignInvestments changes #1895

Merged

chore: add missing cleanup

0357b4e

lemunozm reviewed Jul 11, 2024

View reviewed changes

fixes + ignore failing tests

75bb892

fmt

ec77544

tests: fix message indices

132f946

lemunozm approved these changes Jul 12, 2024

View reviewed changes

wischli marked this pull request as ready for review July 12, 2024 12:08

wischli merged commit e95db39 into feat/lp-v2 Jul 12, 2024
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: LPv2 message reorder #1892

feat: LPv2 message reorder #1892

wischli commented Jun 28, 2024 •

edited

Loading

lemunozm Jul 2, 2024

lemunozm Jul 10, 2024

lemunozm left a comment

lemunozm commented Jul 11, 2024

lemunozm commented Jul 12, 2024 •

edited

Loading

wischli commented Jul 12, 2024

lemunozm commented Jul 12, 2024

		// TODO(@Luis): Apply delta instead of remaining to foreign investments
		fulfilled_invest_amount: u128,

feat: LPv2 message reorder #1892

feat: LPv2 message reorder #1892

Conversation

wischli commented Jun 28, 2024 • edited Loading

Description

Checklist:

lemunozm Jul 2, 2024

Choose a reason for hiding this comment

lemunozm Jul 10, 2024

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

lemunozm commented Jul 11, 2024

lemunozm commented Jul 12, 2024 • edited Loading

wischli commented Jul 12, 2024

lemunozm commented Jul 12, 2024

wischli commented Jun 28, 2024 •

edited

Loading

lemunozm commented Jul 12, 2024 •

edited

Loading