pallets: Add Anchors V2 pallet #1878
Conversation
pallets/anchors-v2/src/lib.rs
Outdated
| /// Storage for document anchors. | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn get_document_anchor)] | ||
| pub type DocumentAnchors<T: Config> = | ||
| StorageMap<_, Blake2_256, (DocumentId, DocumentVersion), T::AnchorIdNonce>; |
There was a problem hiding this comment.
Is there a 1:1 relation among (DocumentId, DocumentVersion) <> T::AnchorIdNOnce?, Could it be the own (DocumentId, DocumentVersion) the id of the anchor id itself?
That way in this case, you do not need an AnchorIdNOnce
There was a problem hiding this comment.
Yes, but then storing personal anchors might be problematic, or we can just use a double map and store (). Lemme try that out.
There was a problem hiding this comment.
Done, please let me know what you think.
There was a problem hiding this comment.
Love it! Super simple now! 💯
cdamian
force-pushed
the
feature/add-anchors-v2-pallet
branch
2 times, most recently
from
fcfdf33
to
179570b
Compare
|
|
cdamian
force-pushed
the
feature/add-anchors-v2-pallet
branch
4 times, most recently
from
7b6dd59
to
d4d20e3
Compare
| @@ -21,7 +21,7 @@ use super::*; | |||
|
|
|||
| #[benchmarks( | |||
| where | |||
| T: Config<Balance = u128, Hash = H256, AnchorIdNonce = u128>, | |||
| T: Config<Balance = u128, Hash = H256>, | |||
There was a problem hiding this comment.
This is not bad, and probably this pallet is only for us, so it will not be an issue. But to explain the why:
These bounds force the user of this pallet to always choose Balance = u128 and Hash = H256 in their runtime if they want to perform the benchmarks. Ideally, we do not want to restrict the usage of the bounds to certain concrete types. We want to allow any type that can be configured by the pallet.
The solution for that is to add extra bounds to those associated types as:
T: Config,
T::Balance: Into<u128>, // Or maybe T::Balance: Default is just enough
T::Hash: Default, // And use later T::Hash::default() instead of H256::from_low_u64_be(1)Not blocker at all, just for reference
There was a problem hiding this comment.
I think we can leave it as it is for now, these benchmarks are still tests at the end of the day and I think it's fine to have some hardcoded types.
cdamian
force-pushed
the
feature/add-anchors-v2-pallet
branch
from
77c0bc9
to
bf3d2e4
Compare
Description
Adds a new anchors pallet, required for the data protocol.
Checklist: