Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old migrations for development 1047 #1840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lemunozm
Copy link
Contributor

Description

Double check it's no longer needed please.

@lemunozm lemunozm added Q0-trivial An issure which is similar to patching code. P7-asap Issue should be addressed in the next days. I11-cleaning No mandatory issue that leave the repo more readable/organized labels May 20, 2024
@@ -1,6 +1,6 @@
[package]
name = "development-runtime"
version = "0.10.46"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this not updated, although I guess it's not a problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this often falls short but it doesn't have any effect anyways.

@lemunozm
Copy link
Contributor Author

Can we merge this soon in order to avoid some issues in polkadot-1.7.2 upgrade with these migrations?

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.89%. Comparing base (ba41880) to head (7cbbb9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   46.87%   46.89%   +0.02%     
==========================================
  Files         165      165              
  Lines       12950    12948       -2     
==========================================
+ Hits         6070     6072       +2     
+ Misses       6880     6876       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not merge this before Dev and Demo are upgraded to 1047. Both are currently on 1046 and need all of these migrations. I wanted to hold on to this until #1812 is merged.

@@ -1,6 +1,6 @@
[package]
name = "development-runtime"
version = "0.10.46"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this often falls short but it doesn't have any effect anyways.

@lemunozm
Copy link
Contributor Author

Ok 👍🏻 Finally, it's not urgent for me for the upgrade by now, so we can leave this here

@lemunozm lemunozm added P5-soon Issue should be addressed soon. and removed P7-asap Issue should be addressed in the next days. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I11-cleaning No mandatory issue that leave the repo more readable/organized P5-soon Issue should be addressed soon. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants