Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gh actions #1814

Merged
merged 12 commits into from
May 7, 2024
Merged

Upgrade gh actions #1814

merged 12 commits into from
May 7, 2024

Conversation

gpmayorga
Copy link
Contributor

Description

The customary upgrade of Github Actions using Dependabot suggestions

dependabot bot and others added 11 commits April 1, 2024 09:37
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.0.0 to 5.3.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@0565240...2cdde99)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5.
- [Release notes](https://github.com/actions/configure-pages/releases)
- [Commits](actions/configure-pages@v4...v5)

---
updated-dependencies:
- dependency-name: actions/configure-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) from 2.2.1 to 2.3.0.
- [Release notes](https://github.com/rtcamp/action-slack-notify/releases)
- [Commits](rtCamp/action-slack-notify@b24d75f...4e5fb42)

---
updated-dependencies:
- dependency-name: rtCamp/action-slack-notify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@343f7c4...e92390c)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.7.1 to 2.7.3.
- [Release notes](https://github.com/swatinem/rust-cache/releases)
- [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md)
- [Commits](Swatinem/rust-cache@3cf7f8c...23bce25)

---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…em/rust-cache-2.7.3' into upgrade-gh-actions
…/login-action-3.1.0' into upgrade-gh-actions
…/action-slack-notify-2.3.0' into upgrade-gh-actions
…s/configure-pages-5' into upgrade-gh-actions
…/build-push-action-5.3.0' into upgrade-gh-actions
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.54%. Comparing base (987aa11) to head (78be4af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   48.54%   48.54%   -0.01%     
==========================================
  Files         169      169              
  Lines       13370    13370              
==========================================
- Hits         6491     6490       -1     
- Misses       6879     6880       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemunozm
Copy link
Contributor

From the changes, I'm not able to know where the new six CI jobs come from. Are they internally added by the new dependencies updated?

@gpmayorga
Copy link
Contributor Author

the new checks aren't new, it is just that when an actions workflow file changes it will trigger that action for the current PR precisely to test if the workflow itself is now broken after such change, in other PRs, if the workflow file did not change, then it will only trigger the worfklows with the pull_request: trigger on them
Example of conditional pull request trigger for Docker build:
https://github.com/centrifuge/centrifuge-chain/actions/runs/8725365260/workflow?pr=1814#L11-L16

@gpmayorga
Copy link
Contributor Author

@wischli or @lemunozm
PING - this should be a no-op

Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@gpmayorga gpmayorga merged commit 23d432c into main May 7, 2024
17 of 18 checks passed
@wischli wischli deleted the upgrade-gh-actions branch May 7, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants