Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chain spec not deterministic #1807

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Apr 11, 2024

Description

As part of my #1756 client checks, I noticed that our ephemeral chain specs did not lead to a deterministic chain spec which blocks all our scripts to register such parachain. The root of this was introduced by myself in #1740 by adding a unix timestamp for the block rewards. Since this timestamp is completely irrelevant for ephemeral chains, I changed it to the default value. This will mint a larger amount of treasury inflation in the first session and then go back to normal.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added the I2-bug The code fails to follow expected behaviour. label Apr 11, 2024
@wischli wischli self-assigned this Apr 11, 2024
@lemunozm
Copy link
Contributor

I remember something about this; thanks for fixing this @wischli !

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.71%. Comparing base (d3a0f0c) to head (8c1e0a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1807   +/-   ##
=======================================
  Coverage   47.70%   47.71%           
=======================================
  Files         170      170           
  Lines       13576    13576           
=======================================
+ Hits         6477     6478    +1     
+ Misses       7099     7098    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wischli
Copy link
Contributor Author

wischli commented Apr 11, 2024

I remember something about this; thanks for fixing this @wischli !

Yes you were not a fan of the reverted code path and thus right already back then 🫡

@wischli wischli merged commit 8f7deb1 into main Apr 11, 2024
14 checks passed
@wischli wischli deleted the fix/chain-spec-not-deterministic branch April 11, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The code fails to follow expected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants