Cleaning: Remove TradingPair
#1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
|
Ready for review. Blocked by #1737 |
lemunozm
force-pushed
the
clear/trading_pair
branch
from
8d9b018
to
40c7bbe
Compare
wischli
requested changes
Feb 22, 2024
mustermeiszer
requested changes
Feb 22, 2024
Comment on lines
-66
to
-96
| // Register trading pairs one by one | ||
| runtime_common::migrations::local_currency::add_bidirectional_trading_pair::Migration< | ||
| super::Runtime, | ||
| UsdcDot, | ||
| LocalCurrencyIdUsdc, | ||
| MinOrderAmount, | ||
| >, | ||
| runtime_common::migrations::local_currency::add_bidirectional_trading_pair::Migration< | ||
| super::Runtime, | ||
| UsdcEth, | ||
| LocalCurrencyIdUsdc, | ||
| MinOrderAmount, | ||
| >, | ||
| runtime_common::migrations::local_currency::add_bidirectional_trading_pair::Migration< | ||
| super::Runtime, | ||
| UsdcBase, | ||
| LocalCurrencyIdUsdc, | ||
| MinOrderAmount, | ||
| >, | ||
| runtime_common::migrations::local_currency::add_bidirectional_trading_pair::Migration< | ||
| super::Runtime, | ||
| UsdcArb, | ||
| LocalCurrencyIdUsdc, | ||
| MinOrderAmount, | ||
| >, | ||
| runtime_common::migrations::local_currency::add_bidirectional_trading_pair::Migration< | ||
| super::Runtime, | ||
| UsdcCelo, | ||
| LocalCurrencyIdUsdc, | ||
| MinOrderAmount, | ||
| >, |
There was a problem hiding this comment.
We still need a migration to kill the storage or trading pairs... WDYT @wischli ?
There was a problem hiding this comment.
Also, we should do the same for AssetPairOrders already removed from the previous PR.
There was a problem hiding this comment.
After another thought, I think it's safer to just reset completely pallet-order-book. We should close, of course, the current pending order before the RU.
lemunozm
commented
Feb 22, 2024
wischli
reviewed
Feb 22, 2024
|
Just done here: 1200eaf (tested with running the node with try-runtime) |
wischli
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
TradingPairstorage and removes all effects on it in the codebase. slack threadChanges and Descriptions
TradingPairstorage fromorder-bookadd_trading_pair()andrm_trading_pair()extrinsics.valid_pair()method fromTokenSwapsandSwapstraits.allow_investment_currency()extrinsic withouttranche_idparameter.disallow_investment_currency()extrinsic withouttranche_idparameter.