Fix Rust docs broken in main branch #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpmayorga
had a problem deploying
to
github-pages
GitHub Actions
Failure
gpmayorga
had a problem deploying
to
github-pages
GitHub Actions
Failure
lemunozm
reviewed
Jan 9, 2024
| @@ -55,11 +58,11 @@ jobs: | |||
| done | |||
|
|
|||
| - name: upload Docs files | |||
| uses: actions/upload-pages-artifact@v2 | |||
| uses: actions/upload-pages-artifact@0252fc4ba7626f0298f0cf00902a25c6afc77fa8 # v3.0 | |||
There was a problem hiding this comment.
Thanks for the version comment!
|
@gpmayorga This PR is still in draft state. Is there anything missing or can we merge this? |
|
All ready to go! I was waiting to make sure the docs are actually passing and publishing then I got distracted with a million fires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since dependabot upgraded the deploy-pages action, the docs deployment to GH pages is broken. This should fix the issue