Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add precompile migration to dev #1581

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: add precompile migration to dev #1581

merged 1 commit into from
Oct 5, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Oct 4, 2023

Description

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added D0-ready Pull request can be merged without special precaution and notification. D8-migration Pull request touches storage and needs migration code. labels Oct 4, 2023
@wischli wischli self-assigned this Oct 4, 2023
lemunozm
lemunozm approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, Demo was not for altair? Until I knew, development did not need runtimes upgrades.

Approved anyways in case I'm not sync with it.

@wischli wischli merged commit 3f52665 into main Oct 5, 2023
10 checks passed
@NunoAlexandre NunoAlexandre deleted the feat/precompile-migration-dev branch October 5, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NunoAlexandre NunoAlexandre NunoAlexandre approved these changes

@lemunozm lemunozm lemunozm approved these changes

@cdamian cdamian Awaiting requested review from cdamian

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer

Assignees

@wischli wischli

Labels
D0-ready Pull request can be merged without special precaution and notification. D8-migration Pull request touches storage and needs migration code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wischli @NunoAlexandre @lemunozm