Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.0 cannot be used with Go modules #76

Closed
F21 opened this issue May 7, 2019 · 5 comments
Closed

v2.2.0 cannot be used with Go modules #76

F21 opened this issue May 7, 2019 · 5 comments

Comments

@F21
Copy link

F21 commented May 7, 2019

Although there is a go.mod file in the repository, the latest version that can be used with Go modules (unless we force it to use a commit) is v2.1.1. This is because the tag is v2.2.0, but the import path is still github.com/cenkalti/backoff.

With go modules, once you get to v2 and up, you need to update the import path to github.com/cenkalti/backoff/v2 and so on.

@cenkalti
Copy link
Owner

I believe it is fixed now. I have followed the instructions here: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

I have bumped the version to v3.0.0 and set v3 as main branch for the project.

@cenkalti
Copy link
Owner

@F21 Can you confirm please?

@F21
Copy link
Author

F21 commented May 11, 2019

@cenkalti Thanks for getting this sorted! This should fix the issue 👍

@bcmills
Copy link

bcmills commented Jul 15, 2019

Note that the v3 release doesn't fix users on the non-/v3 import path. You may want to branch and tag a v2.2.1 release that is the same as v2.2.0 but without the go.mod file.

cenkalti added a commit that referenced this issue Jul 17, 2019
@cenkalti
Copy link
Owner

@bcmills Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants