Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query tx events with >= and <= operators #331

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 13, 2023

Part of celestiaorg/celestia-app#2098

Testing

Before

$ curl http://localhost:1317/cosmos/tx/v1beta1/txs?events=tx.height%3C=10
{
"code": 3,
"message": "invalid event; event tx.height\u003c=10 should be of the format: {eventType}.{eventAttribute}={value}",
"details": [
]
}%

After

$ curl http://localhost:1317/cosmos/tx/v1beta1/txs?events=tx.height%3C=10
{
  "txs": [
  ],
  "tx_responses": [
  ],
  "pagination": null,
  "total": "0"
}%

FLUPs

  1. Cut a release of this repo and bump in celestia-app
  2. Get a fix for this issue merged to upstream cosmos-sdk fix: query tx events with >= and <= operators cosmos/cosmos-sdk#16994 and pull it here

x/auth/tx/service_test.go Show resolved Hide resolved
@rootulp rootulp merged commit c30c073 into celestiaorg:release/v0.46.x-celestia Jul 14, 2023
33 of 34 checks passed
@rootulp rootulp deleted the rp/fix-tx-events branch July 14, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants