chore(deps): exclude cdk dependencies from upgrade #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR locked our CDK version to
1.108.0inpackage.json. It however did not disable those deps from being upgraded byncuin the upgrade workflow.The reason we didn't see cdk upgrades since is actually because the upgrade workflow is failing.
This is the same error we thought would be resolved after ejecting from the
AwsCdkLibrary- but apparently it didn't solve it.Long story short, this PR makes it so the upgrade workflow doesn't try to upgrade cdk deps, enforcing the lock, and coincidentally bypassing the
yarnproblem (which we still need to figure out).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license