Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webkit_jscc
calling convention, which was removed in LLVM 18, this was breaking the testLLVM Release notes: https://releases.llvm.org/18.1.0/docs/ReleaseNotes.html
A couple more things to note:
LLVMGetOrdering
(in Test failures from LLVM C API accessor issues #44) was fixed, so I was hoping that'd mean we could run the tests in debug mode. However, LLVM 18 also introduced a new issue withatomicrmw
instructions that caused a similar crash when running the tests in debug mode. That should now be fixed come LLVM 19, and I'll update the issue with more details