Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcm2bidsphysio.py localvariable 'physio_label' referenced before assignment #5

Closed
benjamin-zimmerman opened this issue Nov 24, 2020 · 10 comments

Comments

@benjamin-zimmerman
Copy link

I tried using the docker container latest and v4.2 with command:

physio2bidsphysio --infile <sourcedata.dcm> --bidsprefix <bidsfolder/siemensCMRR_bold.nii.gz> --verbose

with output:

image

After Parsing waveform 0 (PULS), 1 (RESP), and 2 (EXT).

@pvelasco pvelasco reopened this Nov 25, 2020
@pvelasco
Copy link
Collaborator

Thanks for reporting this issue.
GitHub automatically closed this issue, but the new Docker image is not ready yet. It will be shortly.

@pvelasco
Copy link
Collaborator

@benjamin-zimmerman,
Can you please try with the latest (as of today) docker image?

docker pull cbinyu/bidsphysio:v4.3.1

Thanks!

@benjamin-zimmerman
Copy link
Author

Thanks for responding to this issue! I'm getting a new error now, which prevents me from seeing if this error is resolved.

The error is "dcm2bids( ) got multiple values for argument 'verbose'. This occurs whether or not I use the verbose flag.

image

Let me know if you'd prefer for me to open a new issue instead of putting this here.

pvelasco added a commit that referenced this issue Nov 25, 2020
It modifies `physio2bidsphysio` accordingly.
Addresses second part of #5
@pvelasco
Copy link
Collaborator

@benjamin-zimmerman,
Thanks for catching this new bug. I think I have fixed it. Do you mind trying with the new Docker image?

docker pull cbinyu/bidsphysio:v4.3.2

@benjamin-zimmerman
Copy link
Author

benjamin-zimmerman commented Nov 25, 2020

I'm still receiving the same error (multiple values for argument 'verbose') with bidsphysio:v4.3.2. :

image

@pvelasco
Copy link
Collaborator

For some reason Docker didn't install the newest versions of the packages. I modified the Dockerfile to fix it.
Do you mind trying it again? Remove the previous one and pull it again:

docker rmi cbinyu/bidsphysio:v4.3.2
docker pull cbinyu/bidsphysio:v4.3.2

@benjamin-zimmerman
Copy link
Author

Thanks, now I am getting a new error:

image

again after parsing waveform 0, 1, and 2.

Please let me know if this could be an error in my physio .dcm, and I could provide more info.

@pvelasco
Copy link
Collaborator

Could you please send me your physio .dcm file so that I take a look?
pablo dot velasco at nyu dot edu

Thanks

pvelasco added a commit that referenced this issue Nov 30, 2020
Addresses #5

Versions 4.3.3 (full pkg) and 1.4.3 (sub-pkgs)
@pvelasco
Copy link
Collaborator

OK. I think it is fixed now.
You can try with

docker pull cbinyu/bidsphysio:v4.3.3

Thanks a lot for your help.

@benjamin-zimmerman
Copy link
Author

Everything appears to work on my end now! Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants