Merge pull request #3083 from catchpoint/lh_metrics_fix

handling metricSaving scores
catchpoint · Jul 15, 2024 · e044c0a · e044c0a
2 parents 7512a4f + 5878eb1
commit e044c0a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/www/include/lighthouse-page.inc.php b/www/include/lighthouse-page.inc.php
@@ -136,10 +136,12 @@
 
             $passed = $scoreMode !== 'informative'; // unless info, pass by default
             $scoreDesc = "pass";
-            if (($scoreMode === 'binary' && $score !== 1) || ($scoreMode === 'numeric' && $score < 0.9)) {
+            $numericScoreModes = ['numeric', 'metricSavings'];
+            $isScoreNumeric = in_array($scoreMode, $numericScoreModes);
+            if (($scoreMode === 'binary' && $score !== 1) || ($isScoreNumeric && $score < 0.9)) {
                 $passed = false;
                 $scoreDesc = "average";
-                if ($scoreMode === 'numeric' && $score < 0.5) {
+                if ($isScoreNumeric && $score < 0.5) {
                     $scoreDesc = "fail";
                 }
                 if ($scoreMode === 'binary' && $score !== 1) {