Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement hydrogen as craftable fuel for a fuel cell bionic, mainline assorted other things from Catalcysm++ mod #5489

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

This rounds up and ports over some assorted lil things from Cataclysm++, focusing on stuff that seems reasonably vanilla-compatible and/or overrides vanilla stuff to work.

Describe the solution

  1. Ported over Cata++'s alternative recipe for making small batches of charcoal. Uses the same basic selection of tools as in the mod, in a future PR I might implement something in the vein of "level 2 containing quality" to handle things like "generic fire-safe container that isn't necessarily usable for cooking" that recipes such as this (possibly also pitch) might warrant.
  2. Misc: for consistency, added birchbark as an option when putting together a filled charcoal kiln.
  3. Added basic vanilla recipe for making plastic bags using a plastic mold, since at some point we already had a recipe to print them.
  4. Ported over alternative recipe for welding goggles that substitutes spray paint or a charcoal smoker for lenses.
  5. Ported over changes making hydrogen gas a distinct item with fuel value about right for compressed hydrogen, obsoleted hydrogen tanks in favor of 2-liter tanks filled with hydrogen.
  6. Misc: Fixed fuel value of plasma canisters being off by a factor of 10.
  7. Added hydrogen gas at the expected ratio to cvd_diamond crafting requirement, officially making it a craftable alternative to plasma cans for diamond-coating items.
  8. Partially mainlined the plasma pulse cell CBM via adding a hydrogen fuel cell CBM, which the Cata++ plasma cell will become an upgrade to.
  9. Ported over Cata++ recipe for shotgun suppressor, as well as item and recipe for makeshift counterpart.
  10. Ported over recipe for autoclave pouches.
  11. Ported over wire saw, with associated recipe.

Describe alternatives you've considered

I'm torn about how to handle makeshift thermal lances so I didn't port it over just yet. It may warrant reworking how oxygen tanks work so they aren't used as tools either, but I didn't want to do two gas reworks in a row.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.

Additional context

Adding some extra uses for hydrogen gas is also on the table maybe. Maybe a reactor for example, or some other power-related application...

Also if we ever add bionic researchers as a profession, might be a good fit for the new hydrogen CBM?

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant