Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secured lockers and computer action to open them #4703

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

Ali-Anomma
Copy link
Contributor

@Ali-Anomma Ali-Anomma commented May 27, 2024

Purpose of change

Subways need more content, and parcel lockers has beengetting popular on subways recently.
Also who doesnt want to be a porch pirate amirite?

Describe the solution

Modified computers "open doors" function to make lockers open instead (for some reason it only worked on terrains so this locker is a terrain now)

Describe alternatives you've considered

Making a cargo holding area that can be accesible with locked door.

Testing

MSYS2 with Windows 10
injected following code on the bank map computer:
"computers": { "6": { "name": "Escargot Express Parcel Locker Access", "security": 1, "options": [ { "name": "Mainentance mode: Open All Lockers", "action": "open_locker" } ], "failures": [ { "action": "alarm" } ] }

Additional context

image
image

Checklist

  • Add secured lockers and make them pickable

  • Add computer action to open lockers remotely

  • Put secured lockers in various places such as military buildings to store valuable items

  • Using handful of lockers and one computer, create parcel lockers

  • Put parcel lockers on places like subway stations, outside of post offices, malls etc.

  • Add loot pool for parcel lockers, those loot should be both transportable via cargo and valuable to player. So jewelries, clothes or entertainment stuff will only work as filler; real loot will be SD cards, drugs, "criminal" CBM's, lab chemicals like ampoulle, lab books, small equpment such as military grade NV glasses etc.

  • Somehow add a very tiny chance to spawn a live bomb on locker

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels May 27, 2024
Copy link
Contributor

autofix-ci bot commented May 27, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Ali-Anomma
Copy link
Contributor Author

Purpose of change

Subways need more content, and parcel lockers has beengetting popular on subways recently. Also who doesnt want to be a porch pirate amirite?

Describe the solution

Modified computers "open doors" function to make lockers open instead (for some reason it only worked on terrains so this locker is a terrain now)

Describe alternatives you've considered

Making a cargo holding area that can be accesible with locked door.

Testing

MSYS2 with Windows 10 injected following code on the bank map computer: "computers": { "6": { "name": "Escargot Express Parcel Locker Access", "security": 1, "options": [ { "name": "Mainentance mode: Open All Lockers", "action": "open_locker" } ], "failures": [ { "action": "alarm" } ] }

Additional context

image image

Checklist

  • Add secured lockers and make them pickable
  • Add computer action to open lockers remotely
  • Put secured lockers in various places such as military buildings to store valuable items
  • Using handful of lockers and one computer, create parcel lockers
  • Put parcel lockers on places like subway stations, outside of post offices, malls etc.
  • Add loot pool for parcel lockers, those loot should be both transportable via cargo and valuable to player. So jewelries, clothes or entertainment stuff will only work as filler; real loot will be SD cards, drugs, "criminal" CBM's, lab chemicals like ampoulle, lab books, small equpment such as military grade NV glasses etc.
  • Somehow add a very tiny chance to spawn a live bomb on locker
  • Add cargo boxes that can be dissasembled to reveal its contents, sort of like a loot box. Both normal cargo and box can be found in lockers

  • With that, spawn cargo boxes in various places, in apartments, bikes, in front of homes

  • An option to pay for unattended cargo, as it is rendered obsolote after its owners didnt take it for weeks. Making sure it is balanced and be worth it. Maybe it is quick and silent so you can do your loot in seconds. Picking and hacking would take too long, torching and faling to hack is too loud. It can also help early game characters too.

@RoyalFox2140
Copy link
Collaborator

There is a typo on Mainentance, its Maintenance. Since a lot of our community isn't native english speakers if you need help on the grammar or spelling I'll look at it when it's ready for review.

@scarf005 scarf005 changed the title draft: Add secured lockers and computer action to open them feat: Add secured lockers and computer action to open them May 28, 2024
@Lamandus
Copy link
Contributor

you can add some regular small cardboard boxes and put them in there. Maybe place some duct tape at a table near of it. (and a table itself), sometimes they try to fix broken parcels.

@Lamandus
Copy link
Contributor

Lamandus commented Jul 3, 2024

are you sure that changes belong here?

@Ali-Anomma
Copy link
Contributor Author

are you sure that changes belong here?

cant seem to revert changes on web ui
have to link git from pc

@RoyalFox2140
Copy link
Collaborator

are you sure that changes belong here?

cant seem to revert changes on web ui have to link git from pc

@Ali-Anomma You're going to need to create a new branch and migrate the changes from this PR manually since you've targeted your upload branch and made new pulls afterward. Cleaning this pull up is going to be incredibly difficult but making a new one will be fast if you copy paste your changes to a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants