Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mods/DinoMod): scenarios #4668

Merged
merged 5 commits into from
May 25, 2024
Merged

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented May 18, 2024

Purpose of change

Content parity with DDA

Describe the solution

Ports most scenarios content from DDA. Includes material from CleverRaven/Cataclysm-DDA#56451 and CleverRaven/Cataclysm-DDA#50513 and CleverRaven/Cataclysm-DDA#49968

Describe alternatives you've considered

N/A

Testing

Passes checks. I can't get the latest build to run on my Mac but that shouldn't be related.

Additional context

Permitted by #4665

Checklist

N/A, this adds JSON content

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels May 18, 2024
@scarf005 scarf005 changed the title [DinoMod] scenarios feat(mods/DinoMod): scenarios May 18, 2024
@LyleSY LyleSY marked this pull request as ready for review May 18, 2024 15:22
@scarf005 scarf005 requested a review from chaosvolt May 22, 2024 13:25
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding allowed_locs to vanilla scenarios, you don't have to specify full overrides and probably should be using extend instead.

Here's an example from Aftershock that extends the profession list of an existing scenario: https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/data/mods/Aftershock/scenarios.json#L5

And out of repo, here's an example in MST Extra directly extending starting locations of a vanilla scenario: https://github.com/chaosvolt/MST_Extra_Mod/blob/master/MST_Extra_BN/chargen/scenarios.json#L6

goofy ahhh `extend` implementation
@chaosvolt chaosvolt merged commit 8917570 into cataclysmbnteam:main May 25, 2024
10 checks passed
@LyleSY LyleSY deleted the dinomod_surround branch May 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants