-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add construction of wind turbines on roofs #4463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uuuugh that looks hacky, you've got to specify multiple redundant construction entries for every possible variation of roofs and you didn't even get them all in the process. Plus this falls apart for any building that has outdoor floors instead of roof tiles.
which one did I miss? and yes, there is no good other way to deal with it, the hacky thing is something you can't circumvent. And there are rarely roofs with regular tiles. So that works out for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cataclysm-BN/doc/src/content/docs/en/mod/json/reference/json_info.md
Lines 863 to 864 in 5960913
"pre_flags": [ "DIGGABLE", "FLAT" ], // (Optional) Flags the terrain must have to be built on | |
"pre_terrain": "t_pit", // (Optional) Required terrain to build on |
this PR adds many duplicate entries, maybe we could remove pre_terrain
and replace it with pre_flags
?
the problem is, we don't have a "hard roof" flag. Because a roof tag isn't enough, you shouldn't place it on a thatched roof. Should I really start with a new flag just for this? |
this sounds much better in the long-term, as new flags can be used to simplify other building requirement. current solution of duplicating entries aren't scalable.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose of change
This adds the possibility to construct wind turbines on roofs. It require (imaginary) bolts and metal frames for securing it up there.
Describe the solution
Describe alternatives you've considered
Testing
Additional context
Checklist