Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port): attunements infrastructure #3135

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sayke
Copy link
Contributor

@sayke sayke commented Sep 13, 2023

Summary

SUMMARY: Features "Port over attunements infrastructure"

Purpose of change

I think this should enable the attunement system in Magiclysm, although effect_on_condition and other support code will be needed to port much of the actual Maglclysm attunement content over.

Describe the solution

This just adds some iexamine functionality and support code.

Describe alternatives you've considered

Not doing it

Testing

It seems to work when I examine the altar (which I'm preparing to add in a separate PR after adding effect_on_condition infrastructure as well)

Additional context

None

I think this should enable the attunement system in Magiclysm, although effect_on_condition and other support code will be needed to port much of the actual Maglclysm attunement content over
@github-actions github-actions bot added the src changes related to source code. label Sep 13, 2023
@sayke sayke marked this pull request as draft September 13, 2023 06:31
@scarf005 scarf005 changed the title Port over attunements infrastructure feat(port) over attunements infrastructure Nov 13, 2023
@scarf005 scarf005 changed the title feat(port) over attunements infrastructure feat(port): attunements infrastructure Dec 6, 2023
@Lamandus
Copy link
Contributor

Lamandus commented Apr 2, 2024

Are you still working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants