Expose HostConfiguration type to Compose through Treehouse
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Sep 27, 2022
redwood-treehouse/src/commonMain/kotlin/app/cash/redwood/treehouse/ZiplineTreehouseUi.kt
Outdated
Show resolved
Hide resolved
JakeWharton
commented
Sep 27, 2022
Comment on lines
+69
to
+75
| private val mutableHostConfiguration = | ||
| MutableStateFlow(computeHostConfiguration(context.resources.configuration)) | ||
|
|
||
| override val hostConfiguration: StateFlow<HostConfiguration> | ||
| get() = mutableHostConfiguration |
There was a problem hiding this comment.
Wants Kotlin/KEEP#278
JakeWharton
force-pushed
the
jw/host-display-stuff/2022-09-12
branch
4 times, most recently
from
4a58b9f
to
2543dff
Compare
swankjesse
approved these changes
Oct 3, 2022
| public data class HostConfiguration( | ||
| val darkMode: Boolean = false, | ||
| ) { | ||
| public companion object |
| * @see HostConfiguration | ||
| */ | ||
| @Suppress("unused") // Emulating a CompositionLocal. | ||
| public val HostConfiguration.Companion.current: HostConfiguration |
| val (initialHostConfiguration, hostConfigurationFlow) = hostConfigurations | ||
| composition.setContent { | ||
| val hostConfiguration by hostConfigurationFlow.collectAsState(initialHostConfiguration) | ||
| CompositionLocalProvider(LocalHostConfiguration provides hostConfiguration) { |
There was a problem hiding this comment.
infix functions so weird
|
Really nice |
This will hold more in the future such as the locale, pixel density, etc. For now we propagate whether the host is in dark mode to get things started.
JakeWharton
force-pushed
the
jw/host-display-stuff/2022-09-12
branch
from
2543dff
to
54abf4c
Compare
JakeWharton
changed the title
HostConfiguration type to Compose through Treehouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hold more in the future such as the locale, pixel density, etc. For now we propagate whether the host is in dark mode to get things started.
Screen.Recording.2022-09-27.at.11.00.35.AM.mov
Refs #355