Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and capitalization of words #904

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Fix typos and capitalization of words #904

merged 5 commits into from
Jul 21, 2021

Conversation

mtsknn
Copy link
Contributor

@mtsknn mtsknn commented Jul 13, 2021

No description provided.

README.adoc Outdated Show resolved Hide resolved
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I think that I like having binary names be lowercase and in backticks, as opposed to using the capitalized name. Would you mind changing instances of just, make, bash, and cargo to use backticks?

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@mtsknn
Copy link
Contributor Author

mtsknn commented Jul 20, 2021

Yep, "just" is a common word so I originally capitalized it everywhere to make it clearer that we are talking about just.

I now changed all instances to "just", except in headings it's still "Just". Similarly for make, bash and cargo. (Though line 1545 still has "Bash" instead of "bash" because I think in that case the capitalized name is clearer and consistent with the other names on that line. Similarly for "Cargo" on line 109.)

@mtsknn mtsknn requested a review from casey July 20, 2021 09:15
@casey casey merged commit 7bbc38a into casey:master Jul 21, 2021
@casey
Copy link
Owner

casey commented Jul 21, 2021

Awesome, looks great. This is a big improvement to the consistency of the readme. Thank you very much!

@mtsknn mtsknn deleted the fix-typos branch July 21, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants