Add docs for justfile and justfile_directory functions #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Thank you very much for spotting this! Looks good, aside from a couple small points around wording and punctuation.
CI initially failed, so I fixed those errors in #727 and merged them into this branch, so you might have to pull before pushing.
rminderhoud
force-pushed
the
ralph/doc
branch
from
7782c8b
to
202080c
Compare
|
Sounds good, I updated the wording to match your recommendations and rebased your CI changes. Hopefully it doesn't fail now :) |
|
Awesome, merged. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some basic documentations for the
justfile()andjustfile_directory()that were previously undocumented. These functions were added in #569 but the only information about them was in the source code and this issue #387