-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show aliases in suggestions #624
Conversation
Thanks for the PR! Added some comments inline. |
type: added fixes: - #445
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor comments. Also, this could use an integration test that checks the output is correct.
If you look in tests/integration.rs
, you can find a test called show_suggestion
, which you can make a copy of that adds an alias and checks that it suggests the alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to actually hit the Request changes
radio button, doing that now, which forces me to leave this content-free comment :P
type: changed fixes: - #445
Heya, Anything else I can do for this? |
Just an integration test!
This will mostly be copy pasta from the existing |
type: changed fixes: - #445
Sure thing! I remember seeing that request earlier, but must've hidden it or something. |
Merged! Thank you very much for this! By the way, I don't actually have a changelog generator set up this repo,, so no commit metadata necessary. And, I'm still merging with the "squash and merge" button on Github, since I don't (yet!) have a policy of signing all commits on this repo (that's a new thing I'm trying out for Intermodal). |
Great, happy to contribute! |
#445