Avoid fs::canonicalize #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used `fs::canonicalize` to ensure paths used in search were absolute. This lead to bad behavior when the justfile was symbolic link to a file in another directory. Additionally, on Windows, this produced paths in extended length syntax, which, I believe, has compatibility issues. This diff replaces uses of `fs::canonicalize` with a simpler algorithm that roots path in the invocation directory (which will be a no-op if said path is already absolute), uses `Path::components` to remove extra `/` and `.`, and resolves instances of `..` without following symlinks, i.e. by removing the `..`, and the component that proceeds it.
casey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
fs::canonicalizeto ensure paths used in searchwere absolute. This lead to bad behavior when the justfile was symbolic
link to a file in another directory. Additionally, on Windows, this
produced paths in extended length syntax, which, I believe, has
compatibility issues.
This diff replaces uses of
fs::canonicalizewith a simpler algorithmthat roots path in the invocation directory (which will be a no-op if
said path is already absolute), uses
Path::componentsto remove extra/and., and resolves instances of..without following symlinks,i.e. by removing the
.., and the component that proceeds it.Fixes #538.