Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate .sha256sum files for release artifacts #2323

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Generate .sha256sum files for release artifacts #2323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c19196c
Generate .sha256sum files for release artifacts
twm Aug 27, 2024
589e2a2
Drop the archive-checksum output
twm Aug 27, 2024
bc732da
Use shasum for portability
twm Aug 27, 2024
2608536
Use certutil on Windows
casey Aug 27, 2024
ae24aee
Try sha256sum on windows
casey Aug 28, 2024
b9ce1d1
Merge branch 'master' into sha256sums
casey Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ jobs:
if: ${{ startsWith(github.ref, 'refs/tags/') }}
with:
draft: false
files: ${{ steps.package.outputs.archive }}
files: |
${{ steps.package.outputs.archive }}
${{ steps.package.outputs.archive-checksum }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid needing to create another output variable by doing this:

Suggested change
${{ steps.package.outputs.archive-checksum }}
${{ steps.package.outputs.archive }}.sha256sum

prerelease: ${{ steps.ref-type.outputs.value != 'release' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 4 additions & 0 deletions bin/package
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,14 @@ case $OS in
ARCHIVE=$DIST/just-$VERSION-$TARGET.tar.gz
tar czf $ARCHIVE *
echo "archive=$ARCHIVE" >> $GITHUB_OUTPUT
sha256sum $ARCHIVE > $ARCHIVE.sha256sum
echo "archive-checksum=$ARCHIVE.sha256sum" >> $GITHUB_OUTPUT
;;
windows-latest)
ARCHIVE=$DIST/just-$VERSION-$TARGET.zip
7z a $ARCHIVE *
echo "archive=`pwd -W`/just-$VERSION-$TARGET.zip" >> $GITHUB_OUTPUT
sha256sum $ARCHIVE > $ARCHIVE.sha256sum
echo "archive-checksum=`pwd -W`/just-$VERSION-$TARGET.zip.sha256sum" >> $GITHUB_OUTPUT
;;
esac
Loading