Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for snap #2058

Merged
merged 3 commits into from
May 20, 2024
Merged

Add bash completion for snap #2058

merged 3 commits into from
May 20, 2024

Conversation

albertodonato
Copy link
Contributor

Also switches the snap to core22

@casey
Copy link
Owner

casey commented May 20, 2024

I don't really have the ability to test changes to the snapcraft.yaml file, since I don't have an ubuntu machine at the moment, so just to confirm, you tested this and it works?

@albertodonato
Copy link
Contributor Author

Yes, I tested with a locally built snap and it works for me.

@casey casey enabled auto-merge (squash) May 20, 2024 08:12
@casey casey merged commit d15dad6 into casey:master May 20, 2024
5 checks passed
@casey
Copy link
Owner

casey commented May 20, 2024

Good enough for me! Thank you!

@albertodonato albertodonato deleted the snap-bash-completion branch May 20, 2024 08:22
@albertodonato
Copy link
Contributor Author

Out of curiosity, are you currently publishing the snap manually? AFAICS the last build in the store is quite old

@casey
Copy link
Owner

casey commented May 21, 2024

I am. Or at least I was 😅 I really need to publish a new version.

@albertodonato
Copy link
Contributor Author

FWIW it's possible to set up automation (through the snapcraft site) for the edge channel so that the snap is published on changes to the master branch.

@casey
Copy link
Owner

casey commented May 21, 2024

I tried publishing a new version, but it was pretty annoying, so I gave up and instead removed instructions for installing via the snap in the readme #2070 😅 I think that just may actually now be available in Ubuntu 24.04 using apt.

@zekefast
Copy link

zekefast commented Jun 7, 2024

May be it could be useful to tests changes like this.

There is a project called distobox which allows to spin up different distributions very quickly. I found it very useful for myself. May be you will too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants