Support append() #2046
Support append() #2046
Conversation
addsuffix(suffix, base) takes a `suffix` and a (possibly space-separated) base string,
and append `suffix` to the end of each word in the base string;
for example, addsuffix('.c', 'foo bar baz') -> 'foo.c bar.c baz.c'
|
Seems reasonable to me! How about calling it |
|
Shorter names are okay too. This is carried over from when it was about porting make functions. I'll incorporate the suggestion changes. Thanks for your feedbacks |
There was a problem hiding this comment.
I'm not just maintainer, did you mean to request review from casey? Anyway this looks good to me, append() now behaves according to make documentation of addsuffix as intended. 👍
|
Nice, LGTM! I added |
Pull request was closed
|
Gah, didn't mean to close. |
Got it! |
append(suffix, base)takes aappendand abasestring with space-separated words,and append
suffixto the end of each word in the base string.For example,
append('.c', 'foo bar baz')-> 'foo.c bar.c baz.c'