Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer::analyze borrows rather than clones Ast #1527

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Analyzer::analyze borrows rather than clones Ast #1527

merged 5 commits into from
Jan 25, 2023

Conversation

neunenak
Copy link
Contributor

@neunenak neunenak commented Jan 25, 2023 •
edited
Loading

I was looking at the code around the Analyzer and I realized it was cloning the entire Ast object, which didn't seem to be necessary.

@neunenak neunenak changed the title Analyzer borrowing Analyzer::analyze borrows rather than clones Ast Jan 25, 2023
@casey casey enabled auto-merge (squash) January 25, 2023 03:32
@casey casey disabled auto-merge January 25, 2023 03:33
@casey casey enabled auto-merge (squash) January 25, 2023 04:03
@casey
Copy link
Owner

casey commented Jan 25, 2023

Nice! I removed the 'a lifetime since I think it isn't necessary.

@casey casey merged commit 6ab6588 into casey:master Jan 25, 2023
@neunenak neunenak deleted the analyzer-borrowing branch January 30, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neunenak @casey