Update Sublime syntax instructions #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flagging change to the README for @hustcer. |
|
Nice! Can you also link to the sublime text repo on GitHub, in addition package control? I figure that some users might not be familiar with or use Package Control, so a link directly to the repo might be helpfu. |
|
Sure, LMK if this is what you had in mind. |
|
Nice, looks good to me! |
|
Looks like this missed the release because the branch is out of date? I don't really understand auto-merge. LMK if I need to do anything else. |
|
Ahh, sorry, I hit auto merge, but a test failed, so it never actually merged. The test is flaky, so it's unrelated to this PR. I'll try again. |
|
Thanks @nk9! I saw the update, and now I'm using your new version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the
.sublime-syntaxfile from theextrasdirectory as well, since it's now well out of date. It uses an earlier version of the Sublime syntax definition, which is somewhat closer to the original.tmLanguageformat. There may be a case for keeping it so that users with older versions of Sublime can fall back on it. The version in the Just package requires Sublime Text 4075+, which was released in July 2020. I think 2.5 years is enough time to give users to upgrade, but I wanted to highlight so you can make the final decision.