-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate lazy_static #1442
Eliminate lazy_static #1442
Conversation
Head branch was pushed to by a user without write access
5f319e4
to
f615d3d
Compare
const Mutex::new requires Rust 1.63 |
e597e56
to
f0d0291
Compare
f0d0291
to
07392cf
Compare
Thanks for the PR! I like this change, but I don't think it's worth bumping the MSRV so aggressively. 1.65 was released on Nov. 3, so a little over a month ago. Just doesn't have a formal MSRV policy, but I think I'd like to support at least the last couple of Rust releases. |
It could be 1.63. |
I'm rethinking this. I've tried to be conservative with my MSRV policy, but I don't have a super clear memory for why. I think I want to revisit the reasons for that conservatism, come up with a concrete policy (e.g. support last two Rust releases) and then we can figure out hat new policy allows merging this. Hang tight! |
I would think MSRV doesn't matter much since this isn't a library? |
Just is packaged for a number of distros, and if their version of rust lags behind Just's MSRV, they won't be able to package it, and users won't be able to build it from source. I'm not sure if this is a problem in practice though. |
Based on surveying the internet, it seems like a conservative MSRV isn't super important for binary crates, so I decided to just switch MSRV to stable. Merged, with a bunch of fixes for latest clippy. Thanks for the PR! |
1.63 is required by Mutex::new added in casey#1442
Just a little cleanup.